ENH: adjust uri to use provided source folders for `jupyter_download_nb`

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks

BSD 3-Clause "New" or "Revised" License

74 stars 23 forks source link

ENH: adjust uri to use provided source folders for `jupyter_download_nb` #264

Closed mmcky closed 4 years ago

mmcky commented 4 years ago

This PR adjusts the URI when using the jupyter_download_nb_image_urlpath to use _static paths adjusted for / and relative ../ conditions without having to specify incorrect paths in conf.py option jupyter_static_file_path

mmcky commented 4 years ago

[ ] this should be paired with https://github.com/QuantEcon/lecture-source-py/pull/619

mmcky commented 4 years ago

[ ] needs testing as on a build of lecture-source-py this appears to be using url links rather than relative links for non-download pages in website/jupyter/

[about_py]

https://s3-ap-southeast-2.amazonaws.com/lectures.quantecon.org/py/_static/lecture_specific/about_py/python_vs_rest.png

the download set also has the url prefix.

mmcky commented 4 years ago

This is unlikely to be merged as we will pursue #266