search

QuantEcon / sphinxcontrib-jupyter

A Sphinx Extension for Generating Jupyter Notebooks
BSD 3-Clause "New" or "Revised" License
76 stars 23 forks source link

FEAT: html image links for notebook markdown cells #45

Closed mmcky closed 6 years ago

mmcky commented 6 years ago

This PR implements html based image references in notebook markdown cells. This allows the support of directive elements such as align, height, width, scale, and alt attributes.

This PR removes simple markdown returns for basic image / figure inclusion. This could be enabled at a later date by modifying return_markdown = True when parsing each image node.

This supports all directive attrs identified in: docutils docs, except:

  1. scale, height and width do not mix in the way discussed in the docutils documentation. And currently scale can only be used independently of height and width
  2. :target:, :class:, and :name: are not supported.

Tests have been migrated from #38 via rebase on add-test-image. That PR will be closed.

mmcky commented 6 years ago

See #38 for discussions around migrating to html based image implementation in notebooks rather than a simple markdown solution.