QuantEcon / website

Website for QuantEcon Organisation
https://quantecon.org
8 stars 8 forks source link

Update website #113

Closed HengchengZhang closed 1 year ago

HengchengZhang commented 1 year ago

This PR updates:

mmcky commented 1 year ago

@HengchengZhang can you please update the top level comment box with a short list of things that have changed. Then I will review and take a look.

mmcky commented 1 year ago
HengchengZhang commented 1 year ago

Thanks @mmcky, this PR is still subject to changes and I will ping you once its ready.

mmcky commented 1 year ago

@HengchengZhang can you please update this to fix the merge conflict and bring it up to date so I can review. Thanks.

mmcky commented 1 year ago

@HengchengZhang is it possible to have this ready for review tomorrow?

mmcky commented 1 year ago

@HumphreyYang -- once @HengchengZhang fixes this merge conflict. It would be great if you could take a look across this PR as well. I will also review -- we just want to get this migration right. Any comments are welcome.

HengchengZhang commented 1 year ago

Sorry for my late reply and such a big PR, please have a look at the commits @mmcky and @HumphreyYang and please ping me for more changes/details.

HumphreyYang commented 1 year ago

Many thanks @HengchengZhang, I will go through this and then pass it on to @mmcky.

Hi @mmcky, could you please grant me access to this repo?

Many thanks in advance.

mmcky commented 1 year ago

thanks @HengchengZhang for the the updates.

@HumphreyYang I added write access for you last week so you should be good to go. 👍

mmcky commented 1 year ago

@HengchengZhang are you able to review and incorporate @HumphreyYang feedback and then ping me for a final review.

We need to resolve this PR as soon as possible.

mmcky commented 1 year ago

Thanks @HengchengZhang

I know there is a drive to simplify these pages -- but I think this page would look better with the card style objects (as we had on the more complex filtered page). So perhaps we can try static pages (with the card style objects)

Screenshot 2023-10-25 at 2 42 27 pm

the card style is

Screenshot 2023-10-25 at 2 44 11 pm

then we can make use of the filters on the lectures page to filter for language such as julia and python

mmcky commented 1 year ago

@HengchengZhang the left is this branch while the right is the live site

Do you know why this icon is a bird and not the compact QE?

Screenshot 2023-10-25 at 3 12 45 pm
mmcky commented 1 year ago

@HengchengZhang can you please let me know if you have time to fix these items this week?

HengchengZhang commented 1 year ago

Thanks @HengchengZhang

I know there is a drive to simplify these pages -- but I think this page would look better with the card style objects (as we had on the more complex filtered page). So perhaps we can try static pages (with the card style objects)

Screenshot 2023-10-25 at 2 42 27 pm

the card style is

Screenshot 2023-10-25 at 2 44 11 pm

then we can make use of the filters on the lectures page to filter for language such as julia and python

Thanks @mmcky and main reason I'm making it simpler is that John thought that it's not very nice if we don't have 3's multiplier's number of cards. Cause currently if we go to the lectures filter there will be one missing block on the bottom right.

HengchengZhang commented 1 year ago

@HengchengZhang can you please let me know if you have time to fix these items this week?

Hi @mmcky I will fix the requests this week.

mmcky commented 1 year ago

Thanks @HengchengZhang I know there is a drive to simplify these pages -- but I think this page would look better with the card style objects (as we had on the more complex filtered page). So perhaps we can try static pages (with the card style objects)

Screenshot 2023-10-25 at 2 42 27 pm

the card style is

Screenshot 2023-10-25 at 2 44 11 pm

then we can make use of the filters on the lectures page to filter for language such as julia and python

Thanks @mmcky and main reason I'm making it simpler is that John thought that it's not very nice if we don't have 3's multiplier's number of cards. Cause currently if we go to the lectures filter there will be one missing block on the bottom right.

thanks @HengchengZhang can you match the outline style then of the cards in the linear list format to see what that looks like?'

I also think in the case of lectures it would be nice to have filters for python and julia in my mind (with language badges on each lecture series) top right.

HengchengZhang commented 1 year ago

Thanks @HumphreyYang for the review and I've updated all the changes.

Hi @mmcky do I open a new branch to see how the horizontal cards style looks like with the language filter added? I actually tried horizontal cards style and its basically the current style without the filters label.

mmcky commented 1 year ago

@HengchengZhang the best is to work locally and use screenshots so we can iterate more quickly.

These are my two suggestions. Hopefully it doesn't take long to try it out.

a) Filter for Python or Julia lectures b) Use existing style for card look (to give depth and separation)

Screenshot 2023-10-30 at 11 58 49 am
mmcky commented 1 year ago

@HengchengZhang I just spent some time this morning looking at the css styles

What do you think of this

Screenshot 2023-10-31 at 9 09 04 am

@jstac we could use the label and filter infrastructure to organise by difficulty such as Undergraduate, Intermediate, Graduate?

Alternatively we can remove the label and move the description up a level to make it a bit more compact.

Screenshot 2023-10-31 at 9 17 49 am
mmcky commented 1 year ago

@HengchengZhang I have update the styles for lectures in 3e8ac43 and commented out the filters for now. We may use them to filter or sort for difficulty etc. later on.

Can you let me know where packages, books and others are generated from?

mmcky commented 1 year ago

Can you let me know where packages, books and others are generated from?

OK I think I have figured this out -- they are in pages/code but it is confusing how they are different to _lectures. I think it would be great if we can standardise.

mmcky commented 1 year ago

@HumphreyYang @HengchengZhang I have update the styles associated with the dropdown pages from Projects including Lectures, Code, Books, and Others to standardise how the site is built.

If one of you could cast an eye over the build

https://deploy-preview-113--sleepy-aryabhata-461b8b.netlify.app

and let me know what you think or spot any issues that would be great.

I would like to merge this tomorrow.

cc: @jstac new build of website update.

HumphreyYang commented 1 year ago

Many thanks @mmcky,

There are some very minor link issues. Would you mind if I push some changes to this branch now?

mmcky commented 1 year ago

@HumphreyYang just reviewing myself

This is no longer fully relevant with the reorganised drop-down menu arrangement.

Screenshot 2023-10-31 at 1 02 14 pm

We should:

HumphreyYang commented 1 year ago

@HumphreyYang just reviewing myself

This is no longer fully relevant with the reorganised drop-down menu arrangement.

Screenshot 2023-10-31 at 1 02 14 pm

We should:

  • [ ] remove all as there is no all page
  • [ ] Update to mirror the dropdown menu items

Many thanks @mmcky, this is exactly where I was. I think it would be great if we mirror the dropdown menu.

HumphreyYang commented 1 year ago

I think we can probably remove some of the items in the projects section, as we already have this on the top of the page:

Screenshot 2023-10-31 at 13 06 35

or we can include other projects that are not mentioned in the block above (i.e., forums).

mmcky commented 1 year ago

@HumphreyYang any thoughts on

Should we update to mirror the dropdown menu items?

maybe I will leave it as this for now

Screenshot 2023-10-31 at 1 07 06 pm
mmcky commented 1 year ago

@jstac here is the latest preview of new site

https://deploy-preview-113--sleepy-aryabhata-461b8b.netlify.app

HengchengZhang commented 1 year ago

I think we can probably remove the projects section, as we already have this on the top of the page:

Screenshot 2023-10-31 at 13 06 35

I think Tom and John wants to have the lectures and books on homepage.

HumphreyYang commented 1 year ago

I think Tom and John wants to have the lectures and books on homepage.

Many thanks @HengchengZhang, I was referring to the projects section:

image

They have some overlaps such as lectures and code.

mmcky commented 1 year ago

I agree @HumphreyYang the Lectures and Code are duplicates and can be removed. Let's use this space to showcase Notes and Executable Books for now as Projects we work on.

Screenshot 2023-10-31 at 1 21 50 pm
HumphreyYang commented 1 year ago

Many thanks @mmcky,

There is a link to lectures in about page under Contributing to the lectures section, which has not been updated yet.

I think we can probably replace some links on the guide for contribution with links to the QuantEcon Manual later, which is more stable.

mmcky commented 1 year ago

Thanks @HumphreyYang

I have now reviewed the about page and updated a bunch of links as suggested. I have also updated the content a little to better represent the new structure.

HumphreyYang commented 1 year ago

Many thanks @mmcky,

Back to 2022, we have a title for the sponsors section. Do you think it is necessary to add it back as it is the only section without a title?

HumphreyYang commented 1 year ago

Thanks @HumphreyYang

I have now reviewed the about page and updated a bunch of links as suggested. I have also updated the content a little to better represent the new structure.

Many thanks @mmcky, I clicked all the links, and they are working well for me now.

mmcky commented 1 year ago

Back to 2022, we have a title for the sponsors section. Do you think it is necessary to add it back as it is the only section without a title?

@HumphreyYang this is now in the footer

Screenshot 2023-10-31 at 1 44 58 pm
mmcky commented 1 year ago

@HumphreyYang oh I think you mean this section

Screenshot 2023-10-31 at 1 47 29 pm

@jstac given we have these in the footer now -- do you think we can remove this panel to simplify the page?

HumphreyYang commented 1 year ago

Thanks @HumphreyYang I have now reviewed the about page and updated a bunch of links as suggested. I have also updated the content a little to better represent the new structure.

Many thanks @mmcky, I clicked all the links, and they are working well for me now.

@HumphreyYang this is now in the footer

Screenshot 2023-10-31 at 1 44 58 pm

Apologize for the confusion @mmcky, I was referring to the section here:

Screenshot 2023-10-31 at 13 46 27

Also, What is your opinion on renaming this section

Screenshot 2023-10-31 at 13 48 25

as "Other Projects" and add some of the other items on this page

Screenshot 2023-10-31 at 13 49 05

into this block?

mmcky commented 1 year ago

Thanks for these thoughts @HumphreyYang

as "Other Projects" and add some of the other items on this page

I actually think it would be great to showcase our Open Source contributions (Infrastructure projects). The Other Projects are available through the menubar. The main one we should promote to the front page is Workshops though.

mmcky commented 1 year ago

@HumphreyYang our workshops is front and centre in this panel

Screenshot 2023-10-31 at 1 55 52 pm

but we should add a Past Workshops link to this panel.

HumphreyYang commented 1 year ago

Thanks for these thoughts @HumphreyYang

as "Other Projects" and add some of the other items on this page

I actually think it would be great to showcase our Open Source contributions (Infrastructure projects). The Other Projects are available through the menubar. The main one we should promote to the front page is Workshops though.

Many thanks @mmcky, this also sounds great to me. I think the only concern I have is the title "Open Source" is a little bit too general as our lectures, code, and books are also open-sourced. Perhaps we can say "Open Source Contributions" / "Open Source Infrastructures". Sorry, I couldn't think of a better title for this but I think you will have a much better idea of the title here.

mmcky commented 1 year ago

@HumphreyYang our workshops is front and centre in this panel

Screenshot 2023-10-31 at 1 55 52 pm

but we should add a Past Workshops link to this panel.

@HumphreyYang I was thinking the same. Link has now been added for Past locations text

Screenshot 2023-10-31 at 2 04 20 pm

BTW -- something weird jut happened and I may have edited one of your recent blocks?

mmcky commented 1 year ago

Thanks for these thoughts @HumphreyYang

as "Other Projects" and add some of the other items on this page

I actually think it would be great to showcase our Open Source contributions (Infrastructure projects). The Other Projects are available through the menubar. The main one we should promote to the front page is Workshops though.

Many thanks @mmcky, this also sounds great to me. I think the only concern I have is the title "Open Source" is a little bit too general as our lectures, code, and books are also open-sourced. Perhaps we can say "Open Source Contributions" / "Open Source Infrastructures". Sorry, I couldn't think of a better title for this but I think you will have a much better idea of the title here.

No worries. Thanks for these thoughts. I'll keep it simple and least words for now and we can improve later if we need to.

HumphreyYang commented 1 year ago

BTW -- something weird jut happened and I may have edited one of your recent blocks?

I think one of my comments is deleted : ) nothing too dramatic.

mmcky commented 1 year ago

thanks for review @HumphreyYang

thanks for all the contributions @HengchengZhang @Jingni-Yang

@jstac this is now ready for review.

Only outstanding item is:

HumphreyYang commented 1 year ago

Sorry for the late message @mmcky, there are two more links to be checked on the about page:

One is the link to the team page:

Screenshot 2023-10-31 at 14 13 43

The other is to the direct donation:

Screenshot 2023-10-31 at 14 13 47

It indicates that the donation project has ended.

mmcky commented 1 year ago

thanks @HumphreyYang both of those links are now fixed and updated

jstac commented 1 year ago

Great work guys. Just the issue of the images being too small here: https://deploy-preview-113--sleepy-aryabhata-461b8b.netlify.app/books/

should we remove the large sponsor panel in favour of just listing them in the Sponsor area in the footer.

I think it's good as is. We will probably have to add the Chow Institute soon.

mmcky commented 1 year ago

thanks @jstac