QuantStack / glue-jupyterlab

Glue JupyterLab Extension
https://glue-jupyterlab.readthedocs.io
BSD 3-Clause "New" or "Revised" License
18 stars 7 forks source link

Linkeditor layout #29

Closed brichet closed 1 year ago

brichet commented 1 year ago

This PR is a first iteration on the LinkEditor layout and features.

Peek 2023-04-19 10-38

It includes the 3 panels of the editor (Linked Dataset, Linking and Summary). In this PR, the Linked Dataset widget only allows to select dataset, which displays the list of attributes in the Linking widget. The Linking widget allows to select attributes, but does not glue these attributes yet.

The next steps should probably be done in follow up PRs:

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch _brichet/glue-lab/linkeditorlayout

GabrielaVives commented 1 year ago

It's looking good ! I don't have particular comments for the moment. I will spend time on the UI design (at the time I had only considered the UX of this, I didn't go deep into UI considerations) of the link editor for the next PR. For example the colours, the tabs design, and the titles of each section.

brichet commented 1 year ago

Thanks @trungleduc, I integrated your suggestions.

trungleduc commented 1 year ago

Thanks @brichet