QuantStack / jupytergis

JupyterGIS
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

Linting #15

Closed martinRenou closed 1 week ago

github-actions[bot] commented 1 week ago

Binder :point_left: Launch a Binder on branch martinRenou/jupytergis/linting

brichet commented 1 week ago

If I run jlpm lint on your branch I have

$ git status
Your branch is up-to-date with 'martinRenou/linting'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .github/workflows/build.yml
    modified:   .github/workflows/check-release.yml
    modified:   .github/workflows/prep-release.yml
    modified:   .github/workflows/publish-release.yml
    modified:   packages/base/src/commands.ts
    modified:   packages/base/src/formdialog.tsx
    modified:   packages/base/src/mainview/mainview.tsx
    modified:   packages/base/src/mainview/mainviewmodel.ts
    modified:   packages/base/src/panelview/formbuilder.tsx
    modified:   packages/base/src/panelview/header.tsx
    modified:   packages/base/src/panelview/model.ts
    modified:   packages/base/src/panelview/objectproperties.tsx
    modified:   packages/base/src/panelview/rightpanel.tsx
    modified:   packages/base/src/toolbar/usertoolbaritem.tsx
    modified:   packages/base/src/toolbar/widget.tsx
    modified:   packages/base/src/tools.ts
    modified:   packages/base/src/types.ts
    modified:   packages/base/src/widget.tsx
    modified:   packages/schema/src/doc.ts
    modified:   packages/schema/src/interfaces.ts
    modified:   packages/schema/src/model.ts
    modified:   packages/schema/src/token.ts
    modified:   python/jupytergis_core/src/externalcommand.ts
    modified:   python/jupytergis_core/src/factory.ts
    modified:   python/jupytergis_core/src/index.ts
    modified:   python/jupytergis_core/src/jgisplugin/modelfactory.ts
    modified:   python/jupytergis_core/src/jgisplugin/plugins.ts
    modified:   python/jupytergis_core/src/plugin.ts
    modified:   python/jupytergis_core/style/index.css
    modified:   python/jupytergis_lab/src/index.ts
    modified:   python/jupytergis_lab/src/notebookrenderer.ts
    modified:   python/jupytergis_lab/style/base.css
    modified:   python/jupytergis_lab/style/index.css
    modified:   ui-tests/tests/notebook.spec.ts
    modified:   ui-tests/tests/ui.spec.ts

Looks like you should run it again

martinRenou commented 1 week ago

Indeed! Thanks for trying. Not sure what was going wrong, but starting again from scratch I could see the same as you/