QuantStack / jupytergis

JupyterGIS
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

Map viewers #7

Open martinRenou opened 2 weeks ago

martinRenou commented 2 weeks ago

It seems there are some choices on the front-end libs we can use:

We should make a decision on which one we pick by default.

We will design jupytergis so it can use different viewers (a couple of default viewers, viewers swap-able or new viewers through plugins)

davidbrochart commented 2 weeks ago

We should also consider https://deck.gl. The choice will probably depend on the needs of the project. While OpenLayers and LeafletJS should be similar for raster tiles, Maplibre should be more fit for vector tiles?

martinRenou commented 1 week ago

I edited the top comment

brichet commented 1 week ago

That would be really nice. Do you think we should be able to switch the viewer on the fly ? That would probably mean having some kind of viewer registry.

martinRenou commented 1 week ago

Indeed! We could do that.

I believe that, for the sake of simplicity, we'll start with maplibre-gl. But we should leave the door open to other viewers and allow switching on the fly. We should also provide the proper lumino tokens to allow extensions to provide their own viewers.

Viewers should implement the proper interface (addLayer(), removeLayer etc) so we can use them without really knowing what's under the hood.

brichet commented 1 week ago

Agree with this.

The default layer should be a separate package that adds the default to the registry, like other extensions would do.