search

QuantStack / jupyterlab-drawio

A standalone embedding of the FOSS drawio / mxgraph package into jupyterlab
BSD 3-Clause "New" or "Revised" License
599 stars 75 forks source link

support for JupyterLab 4.0 #119

Open shaneknapp opened 1 year ago

shaneknapp commented 1 year ago

when trying to upgrade to Jupyterlab 4.0, i get the following error when trying to install the latest drawio package:

- package jupyterlab-drawio-0.9.0-pyhd8ed1ab_0 requires jupyterlab >=3.0.0,<4, but none of the providers can be installed

orboan commented 1 year ago

I also need this update to make this extension compatible with jupyterlab 4.0.

linlol commented 7 months ago

Hi,

May I know that is drawio still active here since I can see that 4.0 support is still not yet available.

Also, would it be reviewed and accepted if 4.0 pr provided

Regards

aa403 commented 4 months ago

Same here! 4.x support would be very useful!

linlol commented 4 months ago

Hi @jtpio @jasongrout

May I know the plan of 4.0 support?

If community and contributors plan to work on this, we may just wait...

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

If this project is totally deprecated, maybe I have got to maintain it internally and in private

jtpio commented 4 months ago

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

linlol commented 4 months ago

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

it could be kinda difficult I guess...

Since pyproject toml looks quite old. After implement upgrade script, there shall still be lots of work to do.

May have a try recently

linlol commented 4 months ago

@jtpio so far there is almost nothing on pyproject toml, how about standardize it like a textbook labextension? For further maintainence?

I did similar thing on ipyaggrid internally create a minimised widget extension first, and migrate aggrid code there then

linlol commented 4 months ago

Yes it would be nice to have compatibility with JupyterLab 4.

If pr from third-party individual are still welcomed, I am happy to work on this in June/July

That would be great, thanks!

Not sure how much effort this would require, but it could be worth looking at the extension upgrade script and other changes listed in https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

Try to start working on this, tracked at below issue and PR

https://github.com/QuantStack/jupyterlab-drawio/issues/120

https://github.com/QuantStack/jupyterlab-drawio/pull/121

feel free to raise your advise here, hopefully it would not take too long