search

QuantStack / quantstack.github.io

QuantStack website
https://quantstack.net
12 stars 45 forks source link

Default to American English #145

Closed jtpio closed 6 days ago

jtpio commented 2 months ago

For consistency across the website, it would be nice to default to American English.

Currently, there might be some inconsistencies, for example:

https://quantstack.net/projects/

image

https://quantstack.net/

image

HaudinFlorence commented 6 days ago

It seems that PRs #147 and #152 have addressed this issue. @jtpio @arjxn-py Could you please confirm me that this is ok ?

HaudinFlorence commented 6 days ago

I can still see an UK english occurrence of organises somewhere. Does it mean that there is an issue with the pre-commit-hook ? Thanks

arjxn-py commented 6 days ago

Hi @HaudinFlorence

It seems that PRs https://github.com/QuantStack/quantstack.github.io/pull/147 and https://github.com/QuantStack/quantstack.github.io/pull/152 have addressed this issue.

Yes, these PRs have addressed this issue

I can still see an UK english occurrence of organises somewhere. Does it mean that there is an issue with the pre-commit-hook ? Thanks

This is because the pre-commit hook auto update has been set to monthly and this specific occurrence has been added last week, we can either wait for the auto-update or can manually trigger it too. We can also increase the frequency of pre-commit auto-update from monthly to weekly, if we want.

HaudinFlorence commented 6 days ago

Hi Arjun @arjxn-py Thanks for the precisions. Maybe yes a weekly occurence may be better. Thanks a lot.

arjxn-py commented 6 days ago

Maybe yes a weekly occurrence may be better.

Done in #177, thanks for the quick response :)

HaudinFlorence commented 6 days ago

@arjxn-py Thanks