search

Quantco / metalearners

MetaLearners for CATE estimation
https://metalearners.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
34 stars 4 forks source link

Remove git_root from run requirements? #42

Closed jtilly closed 4 months ago

jtilly commented 4 months ago

Does it make sense to have git_root as run requirement? If I install this package from PyPI or conda-forge, there's no guarantee that I'm running this inside a git repo. The only two helper functions inside the package that use git_root are

Here you can just add an argument that tells the functions where to download the data to. If you remove git_root there, it's just a development requirement afterwards.

kklein commented 4 months ago

Very good points - we should do this!