Quantco / metalearners

MetaLearners for CATE estimation
https://metalearners.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
34 stars 4 forks source link

`MetaLearnerGridSearch` example #49

Closed FrancescMartiEscofetQC closed 4 months ago

FrancescMartiEscofetQC commented 4 months ago

Rendered version

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.91%. Comparing base (58c3741) to head (024e605). Report is 35 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ======================================= Coverage 94.91% 94.91% ======================================= Files 15 15 Lines 1476 1476 ======================================= Hits 1401 1401 Misses 75 75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kklein commented 4 months ago

Thanks for working on this :)

Do you have an understanding of why certain hyperparameters in the grid are nans?

Screenshot 2024-07-05 at 4 18 02 PM
FrancescMartiEscofetQC commented 4 months ago

Do you have an understanding of why certain hyperparameters in the grid are nans?

Yes! This is because in this lines the variant_outcome_model is not a LGBMRegressor (a LinearRegression was chosen) therefore the n_estimators or verbose parameters are not defined. I think this default behaviour is nice as it makes clear when some parameter was not used.

kklein commented 4 months ago

Haha, of course. Let's blame it on the nearing weekend

kklein commented 4 months ago

Is the illustration of this css-related box intentional?

Screenshot 2024-07-08 at 11 22 18 AM

FrancescMartiEscofetQC commented 4 months ago

Is the illustration of this css-related box intentional?

Unfortunately yes, it's to change the font size when displaying dataframes, if not it looks like this: Screenshot 2024-07-08 at 11 34 34

I tried using cell tags like remove-cell or remove-input as explained here but with remove-cell the code is not ran and therefore the font is too big and with remove-input it still shows the box but when extended it is empty (not sure if this option is better).