Test suite: one test disables C++ implementation for all subsequent ones - Githubissues

Quantco / pytsql

Run mssql scripts from Python.

BSD 3-Clause "New" or "Revised" License

14 stars 3 forks source link

Test suite: one test disables C++ implementation for all subsequent ones #54

Closed SimeonStoykovQC closed 1 year ago

SimeonStoykovQC commented 1 year ago

All tests that run after

https://github.com/Quantco/pytsql/blob/76996395bf5a8bb4b9043fdf9944865be5871320/tests/unit/test_py_vs_cpp.py#L141-L144

will not use the C++ implementation, and print a misleading warning from here

https://github.com/Quantco/pytsql/blob/76996395bf5a8bb4b9043fdf9944865be5871320/src/pytsql/tsql.py#L150-L155

like in the current CI