search

QuantifiedSelfless / gulper

data ingestion
4 stars 1 forks source link

Mental health #13

Closed peymanmortazavi closed 8 years ago

peymanmortazavi commented 8 years ago

@mynameisfiber @wannabeCitizen ready for y'all to review.

mynameisfiber commented 8 years ago

@peymanmortazavi i'm not exactly sure what the process_* functions do... it seems they return None no matter what and don't seem to have any side effects.

peymanmortazavi commented 8 years ago

@mynameisfiber I broke them down to many functions so I don't end up with one giant function. it adds to the given "quotes" which is an array. it's an odd way of doing this. I could return it instead but it doesn't matter all that much for this processor. your call though!

wannabeCitizen commented 8 years ago

My two cents: if it works, leave it for now. We can clean up later. Right now we have almost too much to do so it's going to be hard to be strict on code.

wannabeCitizen commented 8 years ago

@peymanmortazavi this needs cleaned up and made to be up to spec with new changes in the repo. Are you able to clean it up yourself or do you need me to find the time?