search

QuantifiedSelfless / gulper

data ingestion
4 stars 1 forks source link

Processors #19

Closed wannabeCitizen closed 8 years ago

wannabeCitizen commented 8 years ago

All processors (truth, mirror, and news) are working. I think we could put an hour or two into any of them to make more graceful functions and make more inferences, but they are totally functional and clean for now.

wannabeCitizen commented 8 years ago

This is now compatible with master if anyone wants to review. Truth processor is pretty dirty and could use some cleaning, which I am going to look into, but otherwise it's functional. Trying to think of a better way to construct the sentences for truth game. Also ways of getting more possible facts about people (I feel like the fewer facts about the 2016 reality and more about the person, the better)

wannabeCitizen commented 8 years ago

So unless there's any complaints, I'm going to go ahead and keep pushing new processors to this branch because these all work and are well tested by now, but I'm not sure when those small things with the User() obj are going to change so rather than have 2 PRs to separately deal with, Ima stick to one. If this gets merged before the other processors are done, I'll rebranch at that point.

wannabeCitizen commented 8 years ago

The processors are all working under consistent test. May need some tweaks to make the data better, but this is ready to be master so we can start branching for specific scraper/processor adjustments rather than piling onto this.

@mynameisfiber @peymanmortazavi if either of you can review this and make sure it works for you like it does for us, @mbarrenecheajr and I will love you forever! Like.. even after death :octopus:

peymanmortazavi commented 8 years ago

:+1: good work!