Quantipy / quantipy

Python for people data
MIT License
66 stars 14 forks source link

1416 link col prop test view #1366

Closed LiaStefan closed 7 months ago

alexbuchhammer commented 8 months ago

praise: This is looking fantastic @LiaStefan! I have left one remark in the commit, it is meant as a general thought on the places in the code where we test for the mimic parameter difference between Dimensions and Link setups.

One todo, I think: There are 8 tests that are currently failing, I guess these will be easy-fixes, though, as these must be due to the changes in the mechanism to retrieve the Views.

tests\test_banked_chains.py ....                                         [  1%]
tests\test_batch.py ......................                               [  9%]
tests\test_chain.py ...............                                      [ 15%]
tests\test_chain_old.py .....                                            [ 17%]
tests\test_cluster.py .......                                            [ 19%]
tests\test_complex_logic.py ..................................           [ 32%]
tests\test_dataset.py ........................................           [ 47%]
tests\test_io_dimensions.py .                                            [ 48%]
tests\test_link.py ....                                                  [ 49%]
tests\test_logic_views.py .                                              [ 50%]
tests\test_merging.py .......                                            [ 52%]
tests\test_recode.py .                                                   [ 53%]
tests\test_rim.py ...                                                    [ 54%]
tests\test_rules.py ...............                                      [ 59%]
tests\test_stack.py ................................                     [ 71%]
tests\test_view_manager.py .....F..F..FF.F.F.F.F..                       [ 80%]
tests\test_view_mapper.py ......                                         [ 82%]
tests\test_view_maps.py ....................................             [ 96%]
tests\test_weight_engine.py .......                                      [ 98%]
tests\test_xlsx_formats.py ...                                           [100%]
LiaStefan commented 8 months ago

Thank you @alexbuchhammer ! I've updated the tests to account for the new mimic set up. The view tests run fine now on my end (I have some errors for the Excel tests but those come up regardless of the changes in this branch).

alexbuchhammer commented 8 months ago

Thank you @alexbuchhammer ! I've updated the tests to account for the new mimic set up. The view tests run fine now on my end (I have some errors for the Excel tests but those come up regardless of the changes in this branch).

Yep - I also always skip the Excel tests!

praise: Looks great now:

tests\test_banked_chains.py ....                                         [  1%]
tests\test_batch.py ......................                               [  9%]
tests\test_chain.py ...............                                      [ 15%]
tests\test_chain_old.py .....                                            [ 17%]
tests\test_cluster.py .......                                            [ 19%]
tests\test_complex_logic.py ..................................           [ 32%]
tests\test_dataset.py ........................................           [ 47%]
tests\test_io_dimensions.py .                                            [ 48%]
tests\test_link.py ....                                                  [ 49%]
tests\test_logic_views.py .                                              [ 50%]
tests\test_merging.py .......                                            [ 52%]
tests\test_recode.py .                                                   [ 53%]
tests\test_rim.py ...                                                    [ 54%]
tests\test_rules.py ...............                                      [ 59%]
tests\test_stack.py ................................                     [ 71%]
tests\test_view_manager.py .......................                       [ 80%]
tests\test_view_mapper.py ......                                         [ 82%]
tests\test_view_maps.py ....................................             [ 96%]
tests\test_weight_engine.py .......                                      [ 98%]
tests\test_xlsx_formats.py ...                                           [100%]
alexbuchhammer commented 8 months ago

Looks good to me! Mega!

AndersFreund commented 8 months ago

Great job @LiaStefan 💯