search

Quantisan / docker-clojure

Official Docker image for Clojure
https://hub.docker.com/_/clojure/
MIT License
204 stars 34 forks source link

Debian base images: The Return #175

Closed cap10morgan closed 2 years ago

cap10morgan commented 2 years ago

I ran into some issues with the new Ubuntu-based upstream images. Namely, the annoying tendency of Ubuntu to replace APT / DEB packages with snaps. You can't easily install snaps in Docker containers because they require a daemon to be running.

So then I found the eclipse-temurin images' recommended alternate base image suggestion in their docs and it was pretty simple.

This brings back some Debian-based images using that approach. It also enables parallel image builds for testing b/c I got tired of waiting on serialized builds. :)

cap10morgan commented 2 years ago

I still need to update the tests

cap10morgan commented 2 years ago

Remaining CI failure is due to this babashka issue. I had a PR merged yesterday to fix it, but it's not in a release yet.

cap10morgan commented 2 years ago

OK this is ready for review @Quantisan

cap10morgan commented 2 years ago

I had a look, my mind exploded. Let me know if there's any particular part that you want me to review?

Probably mostly that the concept seems OK and you're fine with the resulting Debian Dockerfiles (particularly how they copy Java from the temurin images, which is recommended in the temurin image docs).

Quantisan commented 2 years ago

so you are providing these debian images in addition to the temurin images? for the use case when user runs into trouble with ubuntu, e.g. their insistent on installing with snaps.

sounds good to me. perhaps provide some guidance in the readme for user to suggest when to use what? our docker tags is getting long.

cap10morgan commented 2 years ago

so you are providing these debian images in addition to the temurin images? for the use case when user runs into trouble with ubuntu, e.g. their insistent on installing with snaps.

Yep, exactly.

sounds good to me. perhaps provide some guidance in the readme for user to suggest when to use what? our docker tags is getting long.

Definitely. I'll do that next.

cap10morgan commented 2 years ago

@Quantisan README updated