search

Quantisan / docker-clojure

Official Docker image for Clojure
https://hub.docker.com/_/clojure/
MIT License
204 stars 34 forks source link

arm64 support for alpine #238

Open lucas42 opened 2 months ago

lucas42 commented 2 months ago

According to the README:

Sometimes there are upstream eclipse-temurin images based on Alpine Linux.

As of 2022-9-29 these are available for the linux/amd64 architecture only.

However, since that was written, it now appears that eclipse-temurin's image supports alpine on architecture linux/arm64/v8 for JDK versions 21 & 22.

Would it be possible for docker-clojure to support arm64 in instances where it's available upstream? Thanks!

cap10morgan commented 2 months ago

@lucas42 Thanks for letting us know about this! We can definitely add these to the build matrix.

cap10morgan commented 2 months ago

I'm working on this but it exposed a blind spot in our variant exclusion subsystem. Namely, it can't currently exclude an architecture from some JDK versions but not others. I'm going to see if I can teach it to do that while also consolidating & cleaning up some non-orthogonal code in that part of the build system.

But it will be a little longer in coming than I'd hoped.

lucas42 commented 2 months ago

No problem! Thanks for taking a look. I'd normally offer to do a pull request myself, but I'm brand new to clojure, so I worry in this case I'd do more harm than good.