search

Quantomatic / zxlive

A graphical tool for the ZX calculus
Apache License 2.0
44 stars 14 forks source link

Clean up some variables not actually used in `MainWindow` #193

Closed dlyongemallo closed 6 months ago

dlyongemallo commented 6 months ago

I haven't thoroughly tested the "rewrite" code as I don't understand the typcial workflow, but purely looking at the code, there doesn't seem to be any reason why rewrite_form, left_graph, and right_graph should be owned by MainWindow rather than by the only functions in which they're used.

dlyongemallo commented 6 months ago

It would be nice if a test were added (see #192) going through a "user journey" for completing a proof using rewrites and so on.