Quantomatic / zxlive

A graphical tool for the ZX calculus
Apache License 2.0
44 stars 14 forks source link

Move UI code for showing errors out of `custom_rule.py`. #240

Closed dlyongemallo closed 3 weeks ago

dlyongemallo commented 3 weeks ago

Incidentally, make the warning dialogs modal (see issue #156).

dlyongemallo commented 3 weeks ago

Two further questions:

jvdwetering commented 3 weeks ago

I think the bool was originally intended to check if the operation succeeded. But since with this commit it instead raises an Exception, that no longer makes sense. Also with this behaviour, supressing the exceptions with show_error also makes less sense so that that parameter can be removed.

dlyongemallo commented 3 weeks ago

Okay, I've removed both the parameter and the return value.