Quantum-Blockchains / dilithium

Pure Rust implementation of of the post-quantum CRYSTALS-Dilithium algorithm
GNU General Public License v3.0
9 stars 1 forks source link

Benchmark is broken #1

Open AaronKutch opened 3 months ago

AaronKutch commented 3 months ago

cargo bench fails because it looks like the name was changed. There are some things that should be updated. And clippy should be used (but some classes of things should have #[allow(clippy::...)]). What is the status of this repo? I think the implementation is much better than the one by Argyle Software, except that some parameterization to reduce duplication probably could have been done.

kostiask commented 3 weeks ago

cargo bench fails because it looks like the name was changed. There are some things that should be updated. And clippy should be used (but some classes of things should have #[allow(clippy::...)]). What is the status of this repo? I think the implementation is much better than the one by Argyle Software, except that some parameterization to reduce duplication probably could have been done.

Than you for your attentio, we will fix in the near future. At this momet we actively work on making our implmentation alinged with recent FIPS 204 so the repo is generaly active.

GaloisField94 commented 3 weeks ago

cargo bench is fixed on branch ML_DSA, it may get merged to main in few weeks.