search

Quantum-Dynamics-Hub / libra-code

https://quantum-dynamics-hub.github.io/libra/index.html
GNU General Public License v3.0
51 stars 47 forks source link

Initial AppleClang support #223

Closed foxtran closed 1 month ago

foxtran commented 2 months ago

This patch fixes numerous of errors related to build of libra with AppleClang.

AppleClang lacks support of OpenMP, so, extra flag for disabling OpenMP can be passed. By default, OpenMP is enabled.

I have also updated CMakeLists, so currently, it requires at least CMake 3.12.

alexvakimov commented 2 months ago

Btw, I really appreciate your contributions, Igor @foxtran , but can you make a separate branch - i'm a bit scared to accept the current changes to the devel one. Not sure it it would all compile for us. Also, have you tested the build for the clang? Perhaps adding some comments for the Mac users - on how to setup the environment and build the code would be really useful.

foxtran commented 2 months ago

Ok. I will leave only source code changes, and return tomorrow with another PR :)

alexvakimov commented 1 month ago

I actually, like some of the CMakeLists changes you did, @foxtran , but it would be better to have either a separate branch or another CMakeLists file (so the users could chose the one that suits them most)