search

Quantum-Game / quantum-game-2

LEGACY open-source version of Quantum Game 2 (Sept 2019 - Oct 2020)
https://quantumgame.io
MIT License
65 stars 16 forks source link

Update typescript eslint and fix all resulting errors #223

Closed Frizi closed 3 years ago

Frizi commented 3 years ago

Previous eslint versions had a typescript related bug that type-only imports were always treated as unused, so an update was needed. New version comes with new ruleset, so the config also had to be adjusted accordingly and newly detected inconsistencies fixed.

One thing that might need some explanation is a change in vuex module definition. The storeModule method is used in order to make use of typescript's stronger type inference on function arguments, and also allows to conviniently supply the right root store type implicitly.

stared commented 3 years ago

Overall, I like it.

What I would like even better is separate commits per thing, vide https://github.com/Quantum-Game/bra-ket-vue/pull/33.