Cleaning quantum-tensor connection code

Quantum-Game / quantum-game-2

LEGACY open-source version of Quantum Game 2 (Sept 2019 - Oct 2020)

https://quantumgame.io

MIT License

65 stars 16 forks source link

Cleaning quantum-tensor connection code #226

Closed sneakyweasel closed 4 years ago

sneakyweasel commented 4 years ago

The game is working smoothly with a very nice performance increase, this PR is mostly to discuss a few things:

Grid information is sent to qt in JSON format and there is a mismatch between the JSON format we are using in QT and QG2, we should discuss what the best data format could be and stick to it ;p
References to qt operators, transitions, etc. from the Vue front-end have been removed and it feels much nicer to have a single point of comm. Still need to fix EncyclopediaBoard.
EncyclopediaBoard and Board are very similar and it might be a good idea to have only one of them to avoid duplication.
QuantumFrame and QuantumSimulation were moved to QT and this version only uses QT Simulation as a input/output point bypassing the need for Photons since there's a lot of duplicate code.

Waiting for your comments!

stared commented 4 years ago

Things like unifying Boards for game and encyclopedia - clearly another PR (with which I would like to wait for @Frizi input - as a lot of things on board, especially related to interaction, may need serious refactoring).

sneakyweasel commented 4 years ago

Everything seems to be working fine expect the indicator for bra-ket-view which somehow breaks and gives a strange error whose only reference is https://github.com/microsoft/TypeScript/issues/28102

sneakyweasel commented 4 years ago

Everything seems to be working fine. CI tests are passing.

Frizi commented 4 years ago

Things like unifying Boards for game and encyclopedia - clearly another PR (with which I would like to wait for @Frizi input - as a lot of things on board, especially related to interaction, may need serious refactoring).

I'm all for it :) As you said, I wouldn't hold this PR back in wait for that change, but I'd definitely like to get rid of repeated logic here.

stared commented 4 years ago

I tried to test it locally, but there is no visible speedup.

(Plus, it did add a multiverse graph. @sneakyweasel, was it an intended change?)

stared commented 4 years ago

There are some conflicts, could you rebase (or at least merge fix conflicts, then I will squash-rebase this part).