search

QuantumBFS / CuYao.jl

CUDA extension for Yao.jl
https://yaoquantum.org
Other
35 stars 8 forks source link

Removed unnecessary type parameters and type piracy #80

Closed jlbosse closed 1 year ago

jlbosse commented 1 year ago

I got some warnings for the mentioned type parameters and about type piracy that is fixed now.

But since expect(op::Scale, reg::CuDensityMatrix) implements exactly the same logic as expect(op::Scale, reg::DensityMatrix) in YaoArrayRegister, is it even needed or can it be removed altogether?

GiggleLiu commented 1 year ago

Sorry, I forgot why I added this patch. If the tests pass locally, I think removing it is better.

jlbosse commented 1 year ago

In that case don't merge yet. I will check if the tests pass tomorrow when I am back at work and update the PR if they do.

jlbosse commented 1 year ago

Yup, as expected the tests also still pass after removing expect(::Scale, ::CuDensityMatrix)

GiggleLiu commented 1 year ago

Thank you! I will tag a new version.