search

QuantumBFS / Yao.jl

Extensible, Efficient Quantum Algorithm Design for Humans.
https://yaoquantum.org
Other
924 stars 122 forks source link

fix rotation gate dispatch #363

Closed GiggleLiu closed 2 years ago

Roger-luo commented 2 years ago

add a test? I think this wasn't detected by current testset

codecov[bot] commented 2 years ago

Codecov Report

Merging #363 (d4b8b62) into master (0540449) will increase coverage by 0.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   85.51%   85.72%   +0.21%     
==========================================
  Files          78       78              
  Lines        3797     3797              
==========================================
+ Hits         3247     3255       +8     
+ Misses        550      542       -8
Impacted Files Coverage Δ
lib/YaoBlocks/src/composite/put_block.jl 100.00% <ø> (ø)
lib/YaoBlocks/src/autodiff/specializes.jl 94.33% <100.00%> (ø)
lib/YaoSym/src/symengine/instruct.jl 71.42% <0.00%> (+57.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 521247c...d4b8b62. Read the comment docs.

GiggleLiu commented 2 years ago

Very hard to test. They finally goes to the same instruct, no effect unless we have a specialized implementation for Rotation gates. Will become noticeable when e.g. we have a hardware that requires dispatching on rotation gates.