QuantumBFS / Yao.jl

Extensible, Efficient Quantum Algorithm Design for Humans.
https://yaoquantum.org
Other
924 stars 122 forks source link

clean up entry table by default! #384

Closed GiggleLiu closed 2 years ago

GiggleLiu commented 2 years ago

Just noticed that if I do not clean up by default, the chain getindex blow up toooooo fast! Do you tag a new version first or you want to finish density matrix PR first? @Roger-luo

codecov[bot] commented 2 years ago

Codecov Report

Merging #384 (b30ca38) into master (fc3046e) will increase coverage by 1.25%. The diff coverage is 96.85%.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   87.47%   88.72%   +1.25%     
==========================================
  Files          72       73       +1     
  Lines        3849     4347     +498     
==========================================
+ Hits         3367     3857     +490     
- Misses        482      490       +8     
Impacted Files Coverage Δ
lib/YaoBlocks/src/YaoBlocks.jl 100.00% <ø> (ø)
lib/YaoBlocks/src/autodiff/mat_back.jl 91.66% <0.00%> (ø)
lib/YaoBlocks/src/composite/composite.jl 75.00% <ø> (-5.00%) :arrow_down:
lib/YaoBlocks/src/primitive/primitive.jl 100.00% <ø> (ø)
lib/YaoBlocks/src/primitive/rotation_gate.jl 91.48% <ø> (+1.74%) :arrow_up:
lib/YaoSym/src/symengine/instruct.jl 71.42% <66.66%> (ø)
lib/YaoArrayRegister/src/instruct.jl 89.80% <87.50%> (-0.05%) :arrow_down:
lib/YaoBlocks/src/composite/tag/dagger.jl 86.36% <92.85%> (+11.36%) :arrow_up:
lib/YaoArrayRegister/src/qudit_instruct.jl 95.55% <95.55%> (ø)
lib/YaoBlocks/src/routines.jl 95.98% <96.15%> (+0.09%) :arrow_up:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 058a156...b30ca38. Read the comment docs.

Roger-luo commented 2 years ago

let's tag new version after density matrix

Roger-luo commented 2 years ago

can you revert the version updates? It's easier for me to just update it with Ion before registering

Roger-luo commented 2 years ago

Just noticed that if I do not clean up by default, the chain getindex blow up toooooo fast!

Good I prefer always do the cleanup eagerly, now there is a concrete reason for it

GiggleLiu commented 2 years ago

can you revert the version updates? It's easier for me to just update it with Ion before registering

Haha, you need to fix your ion, it should be clever enough to detect such version issues.