search

QuantumBFS / Yao.jl

Extensible, Efficient Quantum Algorithm Design for Humans.
https://yaoquantum.org
Other
918 stars 119 forks source link

fix ad error for abstract vector constructors #415

Closed GiggleLiu closed 2 years ago

GiggleLiu commented 2 years ago

The sum and put constructors are still not properly supported. Zygote dispatches these functions to incorrect backward rules. I do not have time to fix all interfaces, after all, the AD engine should be able to figure out the incorrect backward rules specification.

@VarLad

codecov[bot] commented 2 years ago

Codecov Report

Merging #415 (72a5132) into master (2006fd0) will increase coverage by 0.00%. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          73       73           
  Lines        4476     4480    +4     
=======================================
+ Hits         4002     4006    +4     
  Misses        474      474
Impacted Files Coverage Δ
lib/YaoBlocks/src/autodiff/chainrules_patch.jl 83.87% <50.00%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30ebeda...72a5132. Read the comment docs.