Closed jlbosse closed 1 year ago
Base: 88.27% // Head: 88.19% // Decreases project coverage by -0.08%
:warning:
Coverage data is based on head (
933fc78
) compared to base (addf1df
). Patch coverage: 80.00% of modified lines in pull request are covered.:exclamation: Current head 933fc78 differs from pull request most recent head 39d3da8. Consider uploading reports for the commit 39d3da8 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Before this gets merged, I was wondering if it might make more sense to define the different error channels without wrapping the unitaries in PutBlock
s. This allows to wrap the output of bit_flip_channel
in a PutBlock
or KronBlock
and have the same error channel act on many different locations in the circuit. So do
function bit_flip_channel(p)
return unitary_channel([igate(1), X], [1-p, p])
end
instead of
function bit_flip_channel(n::Int, loc::Int; p::Real)
return UnitaryChannel([igate(n), put(n, loc=>X)], [p, 1-p])
end
The CI failure seems unrelated to me and locally compiled docs also look good. So I think this is ready for a review @Roger-luo or @GiggleLiu !
I moved DensityMatrix
back into YaoAPI
and I think all other comments were also addressed. Please let me know if there is anything else that needs to be done, before this can get merged.
@jlbosse great work! thanks!
Continuation of #416 with added documentation, tests and single and two-qubit depolarizing channels as well as getting up to date with master.