Closed jlbosse closed 1 year ago
Patch coverage: 90.62
% and project coverage change: +0.03
:tada:
Comparison is base (
dc9d152
) 88.24% compared to head (61f7e72
) 88.28%.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
after thinking about this a bit, and as @GiggleLiu commented here this function is only used for printing not really address the basis information (it's inside the type parameters), and assuming someone is overloading it for say rydberg
it's a bit strange that qubit_type
is made for basis. This is a quite vague API IMO, we should eventually get rid of it with something more general.
also, I don't think the basis is well supported in YaoBlocks, we probably shouldn't encourage people to put too much effort into building things on top of it.
Fair enough, I will close this then
The title says it all. Only open question from me is, whether we want to export
qubit_type
as part of the general API of anAbstractRegister