search

QuantumBFS / Yao.jl

Extensible, Efficient Quantum Algorithm Design for Humans.
https://yaoquantum.org
Other
928 stars 123 forks source link

Fix tracedist #495

Closed exAClior closed 6 months ago

exAClior commented 7 months ago

Current calculation of trace distance is off by a factor of 1/2. Now the result matches wiki's and documentation's definition

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.74%. Comparing base (e17a32b) to head (eae086d). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #495 +/- ## ========================================== - Coverage 89.03% 87.74% -1.30% ========================================== Files 83 87 +4 Lines 4835 5264 +429 ========================================== + Hits 4305 4619 +314 - Misses 530 645 +115 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GiggleLiu commented 7 months ago

@Roger-luo It makes sense to me, what is your opinion?

GiggleLiu commented 6 months ago

LGTM. Thanks, @exAClior