search

QuantumBFS / YaoExtensions.jl

Useful extensions for Yao
Apache License 2.0
9 stars 3 forks source link

Cleanup autodiff #11

Closed GiggleLiu closed 4 years ago

Roger-luo commented 4 years ago

tests still fail, is this PR ready for review?

Roger-luo commented 4 years ago

I suggest to just use Yao instead of using YaoBlocks etc separately. You just need to add Yao#master as dependency. Our next major release should include all you need in this package (including YaoSym). And you are basically using Yao here... This saves a few using statements for you, and most importantly, it simplifies your compat in Project, you don't need to manage it here, that is the point of meta-package.

NOTE: compat is going to a requirement for General soon (after the auto-merging become default), all the deps requires compat version upper bound

And is there any problem to just overload Yao.apply!, Yao.instruct! etc. instead of writing its absolute module path? if this doesn't work, we should make it work (by importing functions to module Yao), or it just not convenient to build extension packages like this one.

GiggleLiu commented 4 years ago

tests still fail, is this PR ready for review?

yes, only nightly tests fail. I will fix tests soon. It is ready for review now.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5cfed60). Click here to learn what that means. The diff coverage is 77.28%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #11   +/-   ##
========================================
  Coverage          ?   78.4%           
========================================
  Files             ?      28           
  Lines             ?     565           
  Branches          ?       0           
========================================
  Hits              ?     443           
  Misses            ?     122           
  Partials          ?       0
Impacted Files Coverage Δ
src/block_extension/Mod.jl 88.88% <ø> (ø)
src/block_extension/math_gate.jl 94.73% <ø> (ø)
src/block_extension/reflect_gate.jl 100% <ø> (ø)
src/block_extension/ConditionBlock.jl 45.45% <ø> (ø)
src/block_extension/sequence.jl 52.63% <ø> (ø)
src/block_extension/pauli_strings.jl 83.78% <ø> (ø)
src/block_extension/RotBasis.jl 68.96% <ø> (ø)
src/YaoExtensions.jl 100% <ø> (ø)
src/diff_extension/diffs.jl 100% <100%> (ø)
src/easybuild/QFTCircuit.jl 100% <100%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cfed60...c439b81. Read the comment docs.