search

QuantumBFS / YaoExtensions.jl

Useful extensions for Yao
Apache License 2.0
9 stars 3 forks source link

add nshots. in faithful_grad #17

Closed wangleiphy closed 4 years ago

wangleiphy commented 4 years ago

Now it involves Eigen for op due to measure. Need to optimize for it.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f1efe00). Click here to learn what that means. The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #17   +/-   ##
========================================
  Coverage          ?   78.1%           
========================================
  Files             ?      28           
  Lines             ?     571           
  Branches          ?       0           
========================================
  Hits              ?     446           
  Misses            ?     125           
  Partials          ?       0
Impacted Files Coverage Δ
src/gatecount.jl 92.3% <ø> (ø)
src/block_extension/TrivilGate.jl 62.5% <0%> (ø)
src/diff_extension/faithful_opdiff.jl 100% <100%> (ø)
src/block_extension/QFTBlock.jl 33.33% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1efe00...29684b6. Read the comment docs.

wangleiphy commented 4 years ago

One can drop copy in this line https://github.com/QuantumBFS/YaoExtensions.jl/pull/17/files#diff-c6cdcedad6c4dc1343a8c4c8b37a1f81R30, provided you have fixed the meaure issue.

wangleiphy commented 4 years ago

Works on my machine. However, CI has an error: ERROR: LoadError: LoadError: LoadError: LoadError: UndefVarError: @dumpload_fallback not defined

Roger-luo commented 4 years ago

I'll fix this after PRs in YaoBlocks is merged

GiggleLiu commented 4 years ago

3/4 tests passed, but one failed for being too slow.

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

I will decrease the number of nshots in the test and merge this PR directly. @wangleiphy