search

QuantumBFS / YaoExtensions.jl

Useful extensions for Yao
Apache License 2.0
9 stars 3 forks source link

a tiny bug for Yao.EasyBuild.variational_circuit method #40

Closed yuyuexi closed 2 years ago

yuyuexi commented 2 years ago

Hi, there.

I find there might be a bug in the definition of Yao.EasyBuild.variational_circuit method

At line 115 variational_circuit(nbit::Int, nlayer::Int; kwargs...) = variational_circuit(nbit, nlayer, pair_ring(nbit), kwargs...), the right side is not a valid method. So, the third comma should be semicolon. The right definition is as following: variational_circuit(nbit::Int, nlayer::Int; kwargs...) = variational_circuit(nbit, nlayer, pair_ring(nbit); kwargs...)

GiggleLiu commented 2 years ago

Yes, thanks for the bug report. This repo is going to be abandoned, do you mind forwarding it to Yao. After that I can archive this repo.

yuyuexi commented 2 years ago

sure, please check a same issue i raised in Yao.