QuantumBFS / ZXCalculus.jl

An implementation of ZX-calculus in Julia
http://yaoquantum.org/ZXCalculus.jl/dev/
MIT License
47 stars 7 forks source link

Trying to remove layout #77

Closed ChenZhao44 closed 2 years ago

ChenZhao44 commented 3 years ago

In this PR, I try to generate ZXLayout only when it is needed (plotting, converting ZXDiagram to circuits).

codecov[bot] commented 3 years ago

Codecov Report

Merging #77 (c0ce0e0) into master (69a5b5c) will increase coverage by 2.83%. The diff coverage is 96.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   90.93%   93.76%   +2.83%     
==========================================
  Files          11       11              
  Lines        1654     1749      +95     
==========================================
+ Hits         1504     1640     +136     
+ Misses        150      109      -41     
Impacted Files Coverage Δ
src/circuit_extraction.jl 94.82% <ø> (ø)
src/zx_layout.jl 93.75% <50.00%> (-0.37%) :arrow_down:
src/ir.jl 88.00% <90.90%> (+12.86%) :arrow_up:
src/abstract_zx_diagram.jl 97.14% <97.14%> (+97.14%) :arrow_up:
src/zx_graph.jl 95.20% <98.55%> (+2.49%) :arrow_up:
src/zx_diagram.jl 96.83% <100.00%> (-0.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69a5b5c...c0ce0e0. Read the comment docs.

Roger-luo commented 3 years ago

cool, this looks much better! but I'm thinking maybe we should re-think about the layouts and integrate things with Quon, so they can share some implementation and move the plotting related code in seperate package (persumably just YaoPlots), to reduce the core functionality here.

ChenZhao44 commented 2 years ago

I will merge it first after all tests passing. @Roger-luo

Roger-luo commented 2 years ago

need to have some more tests, the testcov is not happy

ChenZhao44 commented 2 years ago

need to have some more tests, the testcov is not happy

The PR will increase codecov now.