QuantumBadger
commented
10 months ago Generally looks good, thank you! I'm a bit concerned about cluttering the video controls with too many options, but I might revisit the design for that soon.
Finally, I set the default setting for displaying the Video Controls to true, because it seems to me to be an elementary thing and people are often confused that there are none (see e.g. https://github.com/QuantumBadger/RedReader/issues/1057).
I agree with this and am planning to do it, but I'll need to consider the impact on existing users of changing the behaviour. The preference change in this PR won't actually work as it doesn't also update PrefsUtility (users will get different behaviour depending on whether they've visited the settings page), but either way I think it's best to keep the change separate from this PR.
folkemat
To be able to change the speed of a video, this PR adds a video speed control setting.
It can be accessed via an icon/button in the playback control. I chose the clock (ic_time_dark) for this (because I couldn't find a more suitable icon). Maybe a dedicated icon would be better.
Tapping on the clock opens a material alert dialogue with a seekbar through which you can set the speed. I added four buttons (0.5x, 1x, 1.5x and 2x speed) as a fast setting underneath the seekbar. The slowest setting is 0.01 and the fastest is 3.0.
The current speed is displayed in brackets next to the time progress.
Demo picture: photo_2024-01-07_20-37-13
Finally, I set the default setting for displaying the Video Controls to true, because it seems to me to be an elementary thing and people are often confused that there are none (see e.g. #1057).