search

QuantumBadger / RedReader

An unofficial open source Android app for Reddit.
GNU General Public License v3.0
2k stars 482 forks source link

Displayed domain on certain posts is incorrect #1168

Open yawnoc opened 10 months ago

yawnoc commented 10 months ago

On certain posts, the displayed domain in parentheses is reddit.com even when Post Properties has a URL with a different domain.

Based on a sample of size two, this seems to be the case for posts that Old Reddit (on a web browser) is able to display as an embedded album (via preview.redd.it), but which are actually linked to an external (non-Reddit) domain.

It should be noted that Old Reddit also incorrectly shows reddit.com in these cases. If indeed it is the Reddit API that is supplying an incorrect domain, then it would be good if RedReader does its own parsing to determine the correct domain based on the actual link URL. (The goal is to avoid unexpected redirection to facebook.com, for example.)

Examples:

Post link RedReader post screenshot RedReader properties screenshot Old Reddit screenshot
103iu5b 103iu5b RedReader post screenshot 103iu5b RedReader properties screenshot 103iu5b Old Reddit screenshot
192tk1z 192tk1z RedReader post screenshot 192tk1z RedReader properties screenshot 192tk1z Old Reddit Screenshot

Above RedReader screenshots are for RedReader v1.22, and the observed behaviour persists to v1.23.1.

Related post (not mine, but led me to the 103iu5b example): https://www.reddit.com/r/RedReader/comments/103wk4j/wrong_domain_showing/

folkemat commented 10 months ago

Seems like these are just Reddit galleries with added links, see https://github.com/QuantumBadger/RedReader/issues/1061

So the displayed domain is not wrong, but the URL in Post Properties is wrong