QuantumBadger / RedReader

An unofficial open source Android app for Reddit.
GNU General Public License v3.0
1.97k stars 484 forks source link

[Bug] Back gesture works twice in photo viewing screen #1230

Open Leonidius20 opened 1 month ago

Leonidius20 commented 1 month ago

Preconditions:

If you try to close the image using the back gesture, not only does it close the image, but also goes back to the previous screen. For example, if you start the app, from the home screen choose All Posts, and then open an image post there, after trying to close the image you will get back all the way to the Home Screen.

The expected result, however, is that you only get back to the All Posts screen.

This issue was not present in 1.23. It appeared in 1.24 and remains in 1.24.1.

I am using Android 12.

Thanks you in advance!

FloatingOctothorpe commented 2 weeks ago

I can also replicate this. One thing that is worth noting is the back gesture is triggered before it's released and again after navigation when it's released:

  1. Open an image/video in full screen mode.
  2. Start the back gesture from the edge of the screen (without releasing).
  3. RedReader will navigate back to the list of posts after ~0.5 a second. (A < indicator will still be shown until you take your finger off the screen).
  4. When you end the touch by taking your finger off the screen a second back action is triggered (normally taking you back to the home screen).

Hopefully the above makes sense, feel free to ask if you've got any questions