QuantumEntangledAndy / neolink

An RTSP bridge to Reolink IP cameras
GNU Affero General Public License v3.0
257 stars 41 forks source link

mqtt server was replaced by broker_addr #149

Closed dgriswo closed 10 months ago

dgriswo commented 10 months ago

mqtt.server was changed to mqtt.broker_addr in 0.6.0

QuantumEntangledAndy commented 10 months ago

Any particular reason you need to change this given that it takes either server or broker_addr

https://github.com/QuantumEntangledAndy/neolink/blob/e41668df532725382e7a32905456cc84c3252511/src/config.rs#L55-L56

dgriswo commented 10 months ago

As I was moving the mqtt config from cameras to global for the upgrade, an error message indicated broker_addr was missing. There other parsing issues that I worked through as well.

The mismatch in the error vs documentation was the intent of the PR.

QuantumEntangledAndy commented 10 months ago

Ok makes sense. Let me know if you find anything else