search

QuantumEntangledAndy / neolink

An RTSP bridge to Reolink IP cameras
GNU Affero General Public License v3.0
358 stars 49 forks source link

Allow custom mic inputs #7

Closed entropin closed 3 years ago

entropin commented 3 years ago

Not sure If this is the right of handeling rust args, but sence I have added it to my fork, am creating a PR any how sence it seam to work fine for me

QuantumEntangledAndy commented 3 years ago

So I tried to get the edits I suggested done in the PR which github says I can do because of the allow edits from contributers checkbox.... Which I was able to do in the github UI but not from the commandline on my machine (kept getting 403). I will just merge and fix it up locally

entropin commented 3 years ago

Yes sorry, I have been away. I did the commit from my project's Linux VM hehe so nano was my attack tool :p

QuantumEntangledAndy commented 3 years ago

Ah good old nano. Be careful though I'm a vim guy so this might make us mortal enemies. Xkcd I apologize for my poor sense of humour.

Anyways your edit is now in the neolink PR I'm making on the main repo. If you want to add anything else can you do it against the refractor branch. It's the same as the talk branch but with a lot of the debug commits squashed.