Closed lkdvos closed 6 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
45cab94
) 84.00% compared to head (ca2dc3c
) 84.04%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/utility/dynamictols.jl | 72.72% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This cleans up some of the keyword arguments of VUMPS that are not necessary when you do not want to use dynamic tolerances. Additionally, it removes
between
, as this is a copy ofBase.clamp
, and streamlines the creation of default subalgorithms. Finally,dynamical
is replaced withdynamic
.Note that this is quite breaking, as many of the original keywords for VUMPS no longer exist. I think this is warranted, and want to include most of these breaking changes in the transition to v0.11.0. Do you think explicit deprecation warnings are necessary/warranted, or can we just make the changes breaking with the argument v0.x can change the interface?