QuantumKitHub / MPSKit.jl

A Julia package dedicated to simulating quantum many-body systems using Matrix Product States (MPS)
MIT License
126 stars 28 forks source link

refactor dynamic tolerances using `ThrottledTol` #118

Closed lkdvos closed 6 months ago

lkdvos commented 6 months ago

This cleans up some of the keyword arguments of VUMPS that are not necessary when you do not want to use dynamic tolerances. Additionally, it removes between, as this is a copy of Base.clamp, and streamlines the creation of default subalgorithms. Finally, dynamical is replaced with dynamic.

Note that this is quite breaking, as many of the original keywords for VUMPS no longer exist. I think this is warranted, and want to include most of these breaking changes in the transition to v0.11.0. Do you think explicit deprecation warnings are necessary/warranted, or can we just make the changes breaking with the argument v0.x can change the interface?

codecov[bot] commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (45cab94) 84.00% compared to head (ca2dc3c) 84.04%. Report is 1 commits behind head on master.

Files Patch % Lines
src/utility/dynamictols.jl 72.72% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## ========================================== + Coverage 84.00% 84.04% +0.03% ========================================== Files 67 68 +1 Lines 3983 3992 +9 ========================================== + Hits 3346 3355 +9 Misses 637 637 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.