search

QuantumLeaps / qpcpp

QP/C++ Real-Time Embedded Framework/RTOS for embedded systems based on active objects (actors) and hierarchical state machines
https://www.state-machine.com/products/qp
371 stars 82 forks source link

Two onStartup() callbacks in qk.cpp run() #20

Closed dominic-valentino closed 1 year ago

dominic-valentino commented 1 year ago

While stepping through the QK run, I noticed there were 2 onStartup() callbacks. One on line 193 and another on line 204. The second is done with interrupts disabled.

Was this on purpose?

mattheweshleman commented 1 year ago

code reference: https://github.com/QuantumLeaps/qpcpp/blob/5c7e0645b169f00e50077b34217ca5b68e7542ed/src/qk/qk.cpp#L193-L204

I don't see two calls in QV, for example: https://github.com/QuantumLeaps/qpcpp/blob/5c7e0645b169f00e50077b34217ca5b68e7542ed/src/qv/qv.cpp#L113

quantum-leaps commented 1 year ago

Thank you for reporting. The repeated call to onStartup() in qk.cpp has been removed. The change has been already pushed to GitHub. --MMS