search

QuantumMechanics / NEM-sdk

NEM Developer Kit for Node.js and the browser
MIT License
137 stars 82 forks source link

Warnings on Vue.js/webpack #53

Open ryo-opening-line opened 6 years ago

ryo-opening-line commented 6 years ago

I'm creating a web service using nem-sdk on Vue.js/webpack and got the following warnings on running "npm run dev".

$ npm run dev
 WARNING  Compiled with 3 warnings

 warning  in ./node_modules/nem-sdk/node_modules/ajv/lib/async.js

119:15-28 Critical dependency: the request of a dependency is an expression

 warning  in ./node_modules/nem-sdk/node_modules/ajv/lib/compile/index.js

13:21-34 Critical dependency: the request of a dependency is an expression

 warning  in ./node_modules/nem-sdk/node_modules/ajv/lib/async.js

96:20-33 Critical dependency: the request of a dependency is an expression

I think request(using ajv) required by nem-sdk would be old. So i made the following change in package.json and then it works fine.

--- package.json.bak    2018-08-13 17:12:17.156614900 +0900
+++ package.json        2018-08-13 17:16:28.069446200 +0900
@@ -56,7 +56,7 @@
     "babel-preset-es2015": "^6.6.0",
     "crypto-js": "3.1.9-1",
     "jquery": "3.0.0",
-    "request": "2.81.0",
+    "request": "2.88.0",
     "sockjs-client": "1.1.4"
   },
   "deprecated": false,

It would be great if you could fix it... Thanks!