search

QuantumMechanics / NEM-sdk

NEM Developer Kit for Node.js and the browser
MIT License
137 stars 82 forks source link

add uglify-js and integrate to package versioning process #7

Closed evias closed 7 years ago

evias commented 7 years ago

this PR contains 2 changes in the package.json:

1) move browserify, through and duplexer dependencies to devDependencies. This is because those are only needed for building the SDK. (difference between dependencies and devDependencies explained here: http://stackoverflow.com/questions/18875674/whats-the-difference-between-dependencies-devdependencies-and-peerdependencies#22004559 )

2) add uglify-js dependency and "minify" npm script + integrate new script in versioning process.

After you have merged this PR you can version to 1.0.1-RC4 with npm and it will build + browserify + minify the SDK and automatically commit & push the first minified files. I didn't do the versioning part because I don't want people to think I take over the whole SDK since this is a complete minified file I believe the versioning process should be left to @QuantumMechanics

Great weekend ahead!

evias commented 7 years ago

yes thank QM :+1:

@Xpedite now when you clone QM's repo you should be able to use npm minify to product the dist/nem-sdk.min.js file :)