search

QuantumPhysique / trale

trale – a simple body weight diary app respecting your privacy
GNU Affero General Public License v3.0
59 stars 8 forks source link

remove date range limitation #100

Closed basings closed 15 hours ago

basings commented 3 weeks ago

Is your feature request related to a problem? Please describe. Adding data prior to 21 is not possible.

Describe the solution you'd like A clear and concise description of what you want to happen. No artificial limitation

Describe alternatives you've considered Using openscale.

braniii commented 3 weeks ago

Hi @basings thank you for your suggestion. The input restriction only applies to manual entries. It should (hopefully!) work when importing the measured values. Initially we've added this limitations because the computational time of the interpolation scales with the overall timespan. So adding a single old measurement, e.g. 2 years in the past, the performance was really bad. With the rewrite of the computation in v0.6.0 this should be less effected.

@gwosd What do you think of simply removing this limitation?

basings commented 3 weeks ago

Thank you for your quick response. Now it makes sense why there was a limitation in the first place. I assume you switched to a rolling window now which would make the limitation obsolte.

I wasn't able to import my multi year entries from openScale, although I respected the space limited file structure as the export suggested. I tried adding the entries manually after that.

gwosd commented 3 weeks ago

@braniii Sounds like a good plan.

@basings Thank you for reporting the limitation

braniii commented 15 hours ago

@basings I've adjusted the code so that you can add dates starting from 1970 (starting of the epoch in dart language). However, I couldn't reproduce the issue with adding backups older than 2 years. In case you are still facing issues with importing backups, please reopen this issue.