search

QuantumPlasmas-IST / TETHYS-Graphene-Hydrodynamic-Simulation

Hydrodynamic simulation of plasmons in graphene
MIT License
6 stars 0 forks source link

[[[BUG]]] at the grid conversion 2D to 1D #34

Closed pcosme closed 4 years ago

pcosme commented 4 years ago

important bug found at the definition of the point surrounding the active cell NE NW SE and SW points need to be revised

pcosme commented 4 years ago

The main issue was that the main and secundary 2D grips do not have the same stride, contrary to what was implemented In the main grip k=i+jNx because the grid is NxNy but in the "_mid" grids k=i+j(Nx-1) because the grid is (Nx-1)(Ny-1) hence the conversion of the neighbouring point to 1D array is not straight forward

seems to bo solved with commit c0295d69be179710a7f62ea34af8a7ff1e51520a Requires testing the solution found increases the number of operations at each cycle so it should be optimized

pcosme commented 4 years ago

Code testes and working. Closing the issue Optimization should be postponed.