search

QuantumQuadrate / CsPyController

GNU Lesser General Public License v3.0
3 stars 3 forks source link

Lock monitor fix #42

Closed cyip92 closed 4 years ago

cyip92 commented 4 years ago

Fixes some issues with the Raspberry Pi laser lock monitor, which as far as I know, is only being used on the Holmium experiment. Also deletes a redundant file for the lock monitor code.

This PR also applies a bit of a band-aid fix for the experiment loop calling preExperiment multiple times at the end of a run, which has also been a minor issue for some people in the past with the origin server. See #41 for more details.

cyip92 commented 4 years ago

I would highly recommend that any experiments which use the optimizer regularly to checkout and test to make sure your experiment works properly with and without the optimizer on this branch, as part of this PR affects how the optimizer runs. My experiment isn't at the point right now where it can thoroughly test the optimizer's behavior, so all I was really able to confirm is that running the optimizer doesn't cause any obvious bugs.

c-poole commented 4 years ago

We have approving reviews for at least one member of each other experiment running of master so this is good to merge.