search

QuantumQuadrate / CsPyController

GNU Lesser General Public License v3.0
3 stars 3 forks source link

Labview [Ready For Testing] #55

Closed c-poole closed 4 years ago

c-poole commented 4 years ago

Removes broken and unused VIs from our labview servers.

c-poole commented 4 years ago

Some modifications to vis ended up being necessary. These modifications are trivial (resulting from renaming the server vis). The deletions all seem to be in order for now. Next step is trying to get consistent installation requirements that will allow everyone to be able to edit and recompile our LabVIEW servers.

c-poole commented 4 years ago

I have modified the README with instructions for how to re-install National Instruments dependencies for testing this PR depending on whether or not the person is starting from scratch. To test this PR, it is necessary for each experiment to follow the instructions in the README and verify that they can run DDS_server.vi and PXI_server.vi (NOT the executables). If you can run both servers and CsPy's functionality appears to be intact, then this is a success. Note that the installation process will take some time. You should expect to need a couple of hours to completely finish the process and test. Keep that in mind when choosing when to start.

c-poole commented 4 years ago

I deleted every VI that wasn't used and relinked the 64 bit systems to use the 32 bit dll we had stashed in the repo so that everything would actually work as expected when opening labview on a 64 bit machine. when I re-saved both DDS and PXI after that this was the result. I don't think it is necessary to merge this since we're planning on replacing the labview entirely. When we are happy with out new system we will just delete the labview files and change the documentation accordingly instead. Depending on the time-line for replacing the DDS we may want to merge in the deletions on the DDS side of things since that will help sift through noise when we attempt to code the replacement. I should have thought to have us check out this branch so we could discard all the unused VIs for the PXI but I guess it is a bit late for that at this point.

c-poole commented 4 years ago

Closing this for now since it is obsoleted by our attempts to replace the labview code with python but I still want to keep the branch in case the DDS changes take longer than expected now that we're back in the lab.