Implement option to read functional waveforms from file

QuantumQuadrate / CsPyController

GNU Lesser General Public License v3.0

3 stars 3 forks source link

Implement option to read functional waveforms from file #62

Closed JuanBohorquez3 closed 3 years ago

JuanBohorquez3 commented 3 years ago

Currently the text editor box in the functional waveforms module is very bare-bones, making modifying complex waveforms tedious and difficult.

A potential solution is to add a text-box and check-box to the module that prompt the module to load the functional waveforms from a file.

JuanBohorquez3 commented 3 years ago

It will be important that the text of the file that is loaded into the functional waveforms module is also saved, so that previous experimental settings can be saved and recovered.

prhuft commented 3 years ago

Additional design notes:

Checkbox(es) will serve as toggles between loading waveform temp file and loading the default waveform file, or loading from the text field.
Whenever a waveform is loaded, regardless of how, it will be written to a temp file in a specified directory
The load from file button should call a wrapper function for the function that is called when CsPy loads up its settings from the hdf5 file. The additional behavior introduced with the wrapper function will be checking the box to load from the temp file so that subsequent runs will continue using the old waveform until the user manually chooses to load the up-to-date waveform file again.

c-poole commented 3 years ago

If the recently merged PR satisfied all the conditions here, please close this issue. In the future, If you open a PR that should close an issue when merged, include the phrase "fixes #X" in the initial description of the PR where X is the issue number and that will make that process automatic.

prhuft commented 3 years ago

Noted.

On Sat, Feb 6, 2021, 2:18 PM Cody Poole notifications@github.com wrote:

If the recently merged PR satisfied all the conditions here, please close this issue. In the future, If you open a PR that should close an issue when merged, include the phrase "fixes #X" where X is the issue number and that will make that process automatic.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/QuantumQuadrate/CsPyController/issues/62#issuecomment-774537744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOYQFAIMICBORMFTHCQUTTS5WP2NANCNFSM4TX2NFRQ .

prhuft commented 3 years ago

Resolved by PR #63