search

QuantumSavory / QuantumClifford.jl

Clifford circuits, graph states, and other quantum Stabilizer formalism tools.
MIT License
103 stars 42 forks source link

Concatenated quantum code #289

Closed royess closed 2 weeks ago

royess commented 3 weeks ago

Implement the concatenated quantum code, which combines two quantum codes into a large one.

royess commented 3 weeks ago

I am a bit unsure about the right way to write the iscss function for the concatenated quantum code.

A concatenated quantum can be either CSS or non-CSS. In this PR, I make iscss return true if the inner and outer codes are both CSS. This can make tests pass but is not a necessary condition in general; two non-CSS codes can also generate a CSS, concatenated code.

I would appreciate some input. Also, please help review this PR. @Krastanov

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (44f618a) to head (0810732). Report is 2 commits behind head on master.

Files Patch % Lines
src/ecc/codes/concat.jl 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #289 +/- ## ========================================== + Coverage 82.20% 82.97% +0.76% ========================================== Files 59 60 +1 Lines 3940 3959 +19 ========================================== + Hits 3239 3285 +46 + Misses 701 674 -27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Krastanov commented 2 weeks ago

Converting back to draft to make it easier for me to track my review backlog. Do not hesitate to convert it back to non-draft and to ping me for another review.