Closed ba2tro closed 5 months ago
Attention: Patch coverage is 97.43590%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 71.42%. Comparing base (
1ebffc0
) to head (17bc052
).
Files | Patch % | Lines |
---|---|---|
src/ProtocolZoo/ProtocolZoo.jl | 90.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I should have more time to look into this tonight if you have a chance to address my comments.
@Abhishek-1Bhatt , thank you, this is merged now!
Please check out the changes I made, in terms of consistency of interface or ease of reading of tests.
Please learn more about how rebasing works in git and github. It is crucially important to get more comfortable with it, as it is the only way to scalably work on projects like this: a follow-up PR can not wait on this to be finished, otherwise work will never be done. Rebasing takes care tracking code changes. Testing should always be so thorough that it takes care of worries about how changes affect other code (even if we were not using much rebasing).
Oh, I also marked a todo in one of the test files -- currently the protocols are tested only for a small finite number of rounds. That can hide many bugs -- it is very important to have tests where the number of rounds is not constrained. You are probably already investigating this in your other PRs, but it is worth mentioning it here.
Builds on #90