search

QuantumSavory / QuantumSavory.jl

A full stack simulator of quantum hardware, from the low-level analog physics to high-level network dynamics. Includes discrete event simulator, symbolic representation for quantum object, and works with many backend simulators.
https://quantumsavory.github.io/QuantumSavory.jl/
MIT License
30 stars 11 forks source link

grid entanglement with multiple paths #106

Closed ba2tro closed 5 months ago

ba2tro commented 6 months ago

Builds on #90

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 97.43590% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.42%. Comparing base (1ebffc0) to head (17bc052).

Files Patch % Lines
src/ProtocolZoo/ProtocolZoo.jl 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #106 +/- ## ========================================== + Coverage 71.14% 71.42% +0.28% ========================================== Files 37 37 Lines 1473 1491 +18 ========================================== + Hits 1048 1065 +17 - Misses 425 426 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Krastanov commented 6 months ago

I should have more time to look into this tonight if you have a chance to address my comments.

Krastanov commented 5 months ago

@Abhishek-1Bhatt , thank you, this is merged now!

Please check out the changes I made, in terms of consistency of interface or ease of reading of tests.

Please learn more about how rebasing works in git and github. It is crucially important to get more comfortable with it, as it is the only way to scalably work on projects like this: a follow-up PR can not wait on this to be finished, otherwise work will never be done. Rebasing takes care tracking code changes. Testing should always be so thorough that it takes care of worries about how changes affect other code (even if we were not using much rebasing).

Krastanov commented 5 months ago

Oh, I also marked a todo in one of the test files -- currently the protocols are tested only for a small finite number of rounds. That can hide many bugs -- it is very important to have tests where the number of rounds is not constrained. You are probably already investigating this in your other PRs, but it is worth mentioning it here.