search

QuantumSavory / QuantumSavory.jl

A full stack simulator of quantum hardware, from the low-level analog physics to high-level network dynamics. Includes discrete event simulator, symbolic representation for quantum object, and works with many backend simulators.
https://quantumsavory.github.io/QuantumSavory.jl/
MIT License
30 stars 11 forks source link

Store time of tagging #114

Closed ba2tro closed 3 months ago

ba2tro commented 4 months ago

Resolves #111

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.40%. Comparing base (a3969d7) to head (0540e90).

:exclamation: Current head 0540e90 differs from pull request most recent head 48f6240

Please upload reports for the commit 48f6240 to get more accurate results.

Files Patch % Lines
src/queries.jl 93.47% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== + Coverage 71.34% 71.40% +0.05% ========================================== Files 37 37 Lines 1525 1528 +3 ========================================== + Hits 1088 1091 +3 Misses 437 437 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ba2tro commented 4 months ago

@Krastanov , any idea what the xvfb startup issue is from(the documentation ci failure)? https://github.com/QuantumSavory/QuantumSavory.jl/actions/runs/8932976512/job/24537665495?pr=114#step:7:564

Krastanov commented 3 months ago

is this ready for review?

ba2tro commented 3 months ago

Yes, sorry my bad, I should've re-requested for review

Krastanov commented 3 months ago

no worries! You might have said so in person, but it helps to have it mentioned here as well in case I forget

ba2tro commented 3 months ago

This seems nearly ready.

I think we are still missing tests for the new functionality, though. Tests that previously would have failed, like requesting filo or fifo for a whole register where we have various slots of the register tagged in arbitrary order. Could you add such tests?

It looks to me like these tests that we already have are what you described? Let me know if I missed something here https://github.com/Abhishek-1Bhatt/QuantumSavory.jl/blob/f606f1baa76236d48bcbdc1065f208ff6628e2df/test/test_tags_and_queries.jl#L74-L100

Krastanov commented 3 months ago

I made some changes and polish. Please check each of the commits I have submitted in case something is off. Most of them have a clear description for why I added them. Those marked fixup are just there to fix silly mistakes I have made as I was working on this.

Krastanov commented 3 months ago

woohoo, this is in!